Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the default rate (and folder size) of backups. #814

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Changing the default rate (and folder size) of backups. #814

wants to merge 4 commits into from

Conversation

ThePansmith
Copy link
Contributor

Reduced the time between backups from 2 hours to 30 minutes.

Breadchild from the discord explains it well

"What is really really important though is the backup frequency, 2 hours is ridiculous for singleplayer. Everytime you exit the world this timer resets as well, so if your play sessions never exceed 2 hours, you never get a backup. Not to mention losing 2 hours of progress would suck even if it was done correctly"

@ThePansmith
Copy link
Contributor Author

ThePansmith commented Oct 18, 2021

Changed maximum folder size from the default of 50 gigabytes to 1 gigabyte.

@ThePansmith ThePansmith changed the title Changing the default rate of backups. Changing the default rate (and folder size) of backups. Oct 18, 2021
@eiis1000
Copy link

Would love to see the backup frequency change put in before 1.3. 1GB might be a bit small though, how come you reduced it from 2?

@Exaxxion
Copy link
Collaborator

I have concerns about changing the default settings of FTB Backups.

While I agree with you that 2h is likely a bit much for the average person in SP, they like anyone else also have the capacity to adjust the configuration to better suit their needs.

1G of total backups is also an issue for players who explore a lot versus those who never leave their base, or for servers with players living in different bases. I've had entire Omni backup folders smaller than 1G and in other packs where I've had to explore for progression I've had worlds that are half a gig each backup.

My inclination is to fall on the Principle of Least Astonishment and not suddenly change this configuration on our players. I prefer to allow players to determine for themselves what customizations are appropriate.

@eiis1000
Copy link

What you're saying makes sense, but I'd bet that most Minecraft modpack players are not aware of the limitations of the backup timer. It's not fair to expect the average player (who may only play for hour-long sessions for example) to 1. realize that there is a built-in backup system, 2. figure out that it's only triggered when they play for long sessions, and 3. find it in configs and change it. I strongly feel changing it to 1h or 30m is the right move here (don't feel so strongly on the backup folder size decrease, but I changed my personal config to 30m and 5G), but if you don't agree I think it's a good idea to include a note in one of the intro quests (or a quest on its own) explaining the 2h backup timer, the fact that the timer resets on world load, and explaining it can be changed in the config.

@Exaxxion
Copy link
Collaborator

I think I would be more amenable to adding a quest in Genesis to point out that it's a thing and that you can change it if you want, rather than changing the defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants