Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CEU #729

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Update CEU #729

wants to merge 4 commits into from

Conversation

ALongStringOfNumbers
Copy link
Member

Brings back the CEU updates dropped in #674 now that CEU has updated to solve the issue that was found in the version present in the update PR.

@ALongStringOfNumbers ALongStringOfNumbers added the dependencies Pull requests that update a dependency file label Apr 19, 2021
@ALongStringOfNumbers ALongStringOfNumbers added this to In progress in Nomifactory via automation Apr 19, 2021
@Exaxxion
Copy link
Collaborator

Thanks, been meaning to look into this again since the dev fixed Tictim/CEU#1.

The changes to how batteries work would probably require some quest rewriting to go along with it. It's my understanding that GTCE batteries should function sanely in them now.

@Exaxxion Exaxxion added this to the 1.3 milestone Apr 20, 2021
@Exaxxion
Copy link
Collaborator

Exaxxion commented May 9, 2021

I tested out the behavior that was patched in 1.0.5.2 and that all seems to be functioning in a way that I'd expect. However, there's a bit of a quirk with unconstrained battery discharging that affects players using 16x CEFs as it actually constrains it to 4A discharge rate per battery (if no power is coming into the CEF to supplement it otherwise).

I reported this as Tictim/CEU#2 and I'll follow the progress of that. If that's fixed so you can get the full 16A from a flux capacitor as before then I see no reason why we can't update. The update is pretty neat.

@Exaxxion
Copy link
Collaborator

Just rebasing the branch off current dev head commit so I can get to reviewing this in proper context

@Exaxxion
Copy link
Collaborator

In testing I was still running into the same kinds of battery drain rate capping behaviors as before. Will need to get in touch with Tictim again and see if we can sort that out.

@Exaxxion
Copy link
Collaborator

In the force push just now I rebased against dev and fixed the conflicts in the four branch commits.

@heisluft
Copy link

heisluft commented Feb 5, 2024

How is this coming along? It seems there has been no activity for quite a while now

@Exaxxion
Copy link
Collaborator

Exaxxion commented Feb 5, 2024

How is this coming along? It seems there has been no activity for quite a while now

The latest available version of CEU, released May 11, 2021, still had issues preventing us from safely updating, as noted in my comment from Sep 21, 2021.

@eiis1000
Copy link

eiis1000 commented Feb 5, 2024

Perhaps the CEU issue should be reopened then? It's currently marked closed.

@Exaxxion
Copy link
Collaborator

Exaxxion commented Feb 5, 2024

I had last spoken with @Tictim again about this problem, as far as I can determine, in August 2022. Perhaps he may be willing to look at it, but it's been a long time and GTCE development effort has long since shifted to GTCEu, which has native RF/EU converters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Nomifactory
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants