Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Reservoirs from Thermal Expansion #388

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Enable Reservoirs from Thermal Expansion #388

wants to merge 2 commits into from

Conversation

NotMyWing
Copy link
Member

@NotMyWing NotMyWing commented Mar 28, 2020

I figured this would be the best way to introduce Reservoirs without having to come up with new recipes.

This PR enables Reservoirs and adds two-way conversion recipes while removing default recipes and leaving dye recipes intact.

Any Portable Tank can be converted 1:1 to Reservoir of its tier and vice versa (including creative). Craft a Reservoir if you need one, then craft it back into a Portable Tank when you no longer need it.

image

Both Portable Tanks and Reservoirs retain contents, display names and enchantments during the conversion.

@NotMyWing NotMyWing added the enhancement New feature or request label Mar 28, 2020
@NotMyWing NotMyWing requested a review from Exaxxion March 28, 2020 13:25
@Exaxxion
Copy link
Collaborator

This is a neat approach but I think we're fine just using the vanilla reservoir recipes. The basic recipe components are already somewhat gregged and a large bucket is not really going to affect game balance.

I know you used 50 for the NBT conversion to cleanly match up, but I think that's excessive for the base reservoir size. I wouldn't mind bumping it up to 16 buckets base size though; I don't get why TE uses 10 and 50 for reservoirs and portable tanks, respectively.

@Exaxxion Exaxxion closed this Apr 15, 2020
@Exaxxion Exaxxion reopened this Apr 15, 2020
@Exaxxion Exaxxion changed the base branch from 1.3-PR to dev April 15, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants