Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traces to debug_traceCall and debug_traceTransaction #469

Merged
merged 4 commits into from
May 28, 2024

Conversation

fvictorio
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: b034b4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fvictorio fvictorio temporarily deployed to github-action-benchmark May 24, 2024 09:39 — with GitHub Actions Inactive
@Wodann Wodann temporarily deployed to github-action-benchmark May 24, 2024 20:39 — with GitHub Actions Inactive
@fvictorio fvictorio changed the base branch from main to feat/verbose-tracing May 27, 2024 14:29
@fvictorio fvictorio temporarily deployed to github-action-benchmark May 27, 2024 16:14 — with GitHub Actions Inactive
@fvictorio fvictorio marked this pull request as ready for review May 27, 2024 16:15
@fvictorio fvictorio requested a review from agostbiro May 27, 2024 16:15
@fvictorio fvictorio added the no changeset needed This PR doesn't require a changeset label May 27, 2024
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM as a quick fix with the caveat, that I'd expect this change to cause a significant slow down in the debug_trace* methods due to doubling tracing work when verbose_tracing = true with hardhat-tracer.

Since neither hardhat-tracer, nor debug_trace* methods are covered by automated benchmarks, I don't know if we fulfill the

Performance is not significantly degraded when used with HH+EDR.

criterion from #299

@fvictorio fvictorio merged commit 42d4254 into feat/verbose-tracing May 28, 2024
31 checks passed
@fvictorio
Copy link
Member Author

Agree, but I think a potential slowdown in the debug_ methods is acceptable, at least for now.

@Wodann Wodann deleted the debug-methods-trace-events branch July 11, 2024 15:20
@Wodann Wodann added this to the EDR v0.4.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants