-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: remove deprecated behavior #1220
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly non-blocking comments, but the following notebooks in tutorials still have os.environ['NIXTLA_ID_AS_COL']
in it:
- 02_cross_validation
- 10_distributed
- 12_using_mlflow
- 19_large_datasets
- 20_conformal_prediction
I removed the uses of datasetsforecast.losses, the ones that set the env variable wouldn't be broken but it can be confusing, so I removed them in 051ec9b. We still have to update all notebooks which have a reset_index in them but I wanted to finish this within my lifetime so I didn't do it here but I'll update this PR when I get time to run those as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Removes the following behavior, which has been deprecated for about a year:
sort_df
tofit
andcross_validation
, we always check if it's sorted.num_workers_loader
to the models constructor, those should now be provided throughdataloader_kwargs
.Also updates the documentation to remove usages of this behavior, docs that use
datasetsforecast.losses
and usesutilsforecast.plotting.plot_series
instead ofStatsForecast.plot