Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk: 3.1.19 -> 4.1.1 #375412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erichelgeson
Copy link

This PR upgrades netatalk 3.1.19 to 4.1.1. Changelog(s) are here https://github.com/Netatalk/netatalk/releases/tag/netatalk-4-1-1

This upgrade is for the unstable channel. The 3.1.x line will be EoL May 2025 and 3.2.x in Sept 2025 - https://github.com/Netatalk/netatalk?tab=security-ov-file#supported-versions

4.x supersedes 3.x and also re-incorporates 2.x features that were dropped.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

I have been working with the netatalk maintainer @rdmark to update and configure the meson build and consulted him for the best defaults for this package.

Tested by

$ cd results
$ sudo bin/netatalk

$ bin/asip-status localhost
AFP reply from localhost:548 via IPv6
Flags: 1  Cmd: 3  ID: 57005
Reply: DSIGetStatus
Request ID: 57005
Machine type: Netatalk4.1.1
AFP versions: AFP2.2,AFPX03,AFP3.1,AFP3.2,AFP3.3,AFP3.4
UAMs: DHX2,DHCAST128
Volume Icon & Mask: Yes
Flags: 
    SupportsCopyFile
    SupportsServerMessages
    SupportsServerSignature
    SupportsTCP/IP
    SupportsSrvrNotifications
    SupportsOpenDirectory
    SupportsUTF8Servername
    SupportsUUIDs
    SupportsExtSleep
    SupportsSuperClient
Server name: nixos
Signature:
2d 07 66 99 08 a6 d0 a6 e6 76 70 5e 79 d4 d2 25  -.f......vp^y..%
                                                  
Network address: 192.168.1.119 (IPv4 address)
UTF8 Servername: nixos

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants