epsonscan2: 6.7.70.0 -> 6.7.70.0-01-2025, pin boost, minor refactor #375409
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epson changes their projects without changing their versions because ¯\_(ツ)_/¯. They also provide no changelogs, because why would they? This seems to at least remove the CMakeCache.txt that was left in the source code distribution. Signed-off-by: Fernando Rodrigues <[email protected]>
This software does not use C++11. Signed-off-by: Fernando Rodrigues <[email protected]>
- Removes a `pname` interpolation. - Updates the `longDescription` so it uses syntax-highlighting code blocks instead of <literal>. - Uses `lib.getExe` instead of hardcoding a `/bin/` path. - Uses the new `lib.systems` standard for declaring platforms. Signed-off-by: Fernando Rodrigues <[email protected]>
|
Thanks! Looks good to me.
|
james-atkins
approved these changes
Jan 21, 2025
Shawn8901
reviewed
Jan 21, 2025
| # There can be multiple different packages identified by the same | ||
| #version, so we also tag them with the month and year shown in | ||
| # the Epson download page. | ||
| version = "6.7.70.0-01-2025"; |
There was a problem hiding this comment.
Shouldn't we then use YYYY-MM?
|
|
||
| system = stdenv.hostPlatform.system; | ||
| system = stdenv.buildPlatform.system; |
There was a problem hiding this comment.
Just as double check as I am still getting confused by the plattforms. We are selecting here which tarballs we want to use for the non free bundles.
Doesnt build platform specify where we are currently building and in the case we are crosscompiling then target the wrong architecture?
I guess at the end it should not make a lot difference as long as no one crosscompiles from aarch to x86, as it's x86 only anyways, but I assume that this is the reason why it was host platform before
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package to the latest release from Epson. Please see the comment in the file for an explanation as to why the version is the way it is.
Pins Boost 1.86 because Epson is too good for C++11.
Fixes up some minor things in the package.
I should also note that this package is currently failing on
master.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.