python3Packages.transformers: don't import torch.distributed on darwin #375117
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
The upstream patch merged. |
|
Would you mind switching the source of the patch to the main branch and adding a comment to remove this patch on the next version ? |
This patch is in the same spirit as d842a19 where import for torch.distributed was patched out for darwin. This other instance of the incorrect import was spotted while packaging lm-eval through the latter test suite.
booxter
force-pushed
the
transformers-for-lm-eval
branch
from
c9b5190 to
519a423
Compare
|
|
Moving to draft so that I can check first if any failures are due to this change. |
|
|
I dont think the failures are related to this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is in the same spirit as
d842a19 where import for torch.distributed was patched out for darwin. This other instance of the incorrect import was spotted while packaging lm-eval through the latter test suite.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.