Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vintagestory: 1.19.8 -> 1.20.3 #375008

Merged
merged 1 commit into from
Jan 26, 2025
Merged

vintagestory: 1.19.8 -> 1.20.3 #375008

merged 1 commit into from
Jan 26, 2025

Conversation

xbreu
Copy link
Contributor

@xbreu xbreu commented Jan 19, 2025

Version update

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 19, 2025
@nix-owners nix-owners bot requested review from GiggleSquid and Artturin January 19, 2025 10:35
@NOTtheMessiah
Copy link
Contributor

Checked this out and did a NIXPKGS_ALLOW_UNFREE=1 NIXPKGS_ALLOW_INSECURE=1 nix-build -A vintagestory and can confirm that this works

So you can check Tested basic functionality of all binary files

Copy link
Contributor

@GiggleSquid GiggleSquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs. Approved

@GiggleSquid GiggleSquid added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 20, 2025
@GiggleSquid GiggleSquid added the 8.has: package (update) This PR updates a package to a newer version label Jan 20, 2025
@niraethm
Copy link

+1 Can confirm it builds with NIXPKGS_ALLOW_UNFREE=1 NIXPKGS_ALLOW_INSECURE=1 and the result runs.

@KamilBaczkowski
Copy link

I have been running this for about a week and it works 👍

@xbreu xbreu changed the title vintagestory: 1.19.8 -> 1.20.1 vintagestory: 1.19.8 -> 1.20.3 Jan 26, 2025
@xbreu xbreu requested a review from GiggleSquid January 26, 2025 02:47
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 26, 2025
@Artturin Artturin merged commit 20d0f5d into NixOS:master Jan 26, 2025
33 of 35 checks passed
@Artturin Artturin mentioned this pull request Jan 26, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants