Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-commander-rs: 0.4.1 -> 0.10.0 #366181

Merged
merged 2 commits into from
Dec 19, 2024
Merged

matrix-commander-rs: 0.4.1 -> 0.10.0 #366181

merged 2 commits into from
Dec 19, 2024

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Dec 18, 2024

Fixes #365830

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff
Copy link
Member

fabaff commented Dec 18, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366181

x86_64-linux

✅ 1 package built:
  • matrix-commander-rs

jcdickinson
jcdickinson approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jcdickinson jcdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on NixOS with my own real conduit server.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Dec 18, 2024
@ofborg ofborg bot requested a review from fabaff December 19, 2024 01:51
fabaff
fabaff approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit e23572c into NixOS:master Dec 19, 2024
43 of 44 checks passed
@aucub aucub deleted the matrix-commander-rs branch December 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanvir1337x Tanvir1337x Tanvir1337x approved these changes

@jcdickinson jcdickinson jcdickinson approved these changes

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: matrix-commander-rs 0.4.1 → 0.10.0
5 participants
@aucub @fabaff @jcdickinson @Tanvir1337x @wegank