xephem: init at 4.2.0 #294622

EstebanMacanek · 2024-03-10T01:24:30Z

Description of changes

Add xephem to nixpkgs.
The Serious Interactive Astronomical Software Ephemeris
https://xephem.github.io/XEphem/Site/xephem.html

Things done

Add a 👍 reaction to pull requests you find important.

pkgs/applications/science/astronomy/xephem/default.nix

pkgs/top-level/all-packages.nix

pkgs/by-name/xe/xephem/package.nix

rafameou · 2024-03-13T16:33:29Z

Please squash your commits: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions
Next time you need to fix something, you should patch+ammend your "init" commit instead of creating new ones, check section 7: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#how-to-create-pull-requests

FliegendeWurst · 2024-11-05T14:49:24Z

pkgs/by-name/xe/xephem/package.nix

+  meta = with lib; {
+    description = "The Serious Interactive Astronomical Software Ephemeris";
+    mainProgram = "xephem";
+    homepage = "https://xephem.github.io/XEphem/Site/xephem.html";
+    license = licenses.mit;
+    maintainers = with maintainers; [ EstebanMacanek ];
+    platforms = platforms.unix;


Suggested change

meta = with lib; {

description = "The Serious Interactive Astronomical Software Ephemeris";

mainProgram = "xephem";

homepage = "https://xephem.github.io/XEphem/Site/xephem.html";

license = licenses.mit;

maintainers = with maintainers; [ EstebanMacanek ];

platforms = platforms.unix;

meta = {

description = "The Serious Interactive Astronomical Software Ephemeris";

mainProgram = "xephem";

homepage = "https://xephem.github.io/XEphem/Site/xephem.html";

license = lib.licenses.mit;

maintainers = with lib.maintainers; [ EstebanMacanek ];

platforms = lib.platforms.unix;

FliegendeWurst · 2024-11-05T14:49:44Z

pkgs/top-level/all-packages.nix

@@ -39617,6 +39617,7 @@ with pkgs;
  vite = libsForQt5.callPackage ../applications/science/misc/vite { };

  xearth = callPackage ../applications/science/astronomy/xearth { };
+


Suggested change

pkgs/by-name/xe/xephem/package.nix

FliegendeWurst · 2025-01-21T14:49:12Z

pkgs/by-name/xe/xephem/package.nix

+    hash = "sha256-TuzXrWoJOAHg31DrJObPcHBXgtqR/KWKFRsqddPzL4c=";
+  };
+
+  sourceRoot = "${src.name}/GUI/xephem";


Seems to cause errors when building

Assembler messages: Fatal error: can't create aa_hadec.o: Permission denied

Do you know where the source code for sourceRoot is? I tried searching for it in NixOS/nix but couldn't find the definition. I think the error might be that sourceRoot changes the mode bits of the parents directories.

sourceRoot is not a formal parameter. It is set as environment variable and used in pkgs/stdenv/generic/setup.sh (line 1300+).

Probably the problem is that the mode bit of parent directories is not changed to allow writing, when using sourceRoot.

FliegendeWurst · 2025-01-21T14:49:53Z

pkgs/by-name/xe/xephem/package.nix

+
+  sourceRoot = "${src.name}/GUI/xephem";
+  postPatch = ''
+    sed -i "s|/etc/XEphem|$out/etc/XEphem|" xephem.c


Suggested change

sed -i "s|/etc/XEphem|$out/etc/XEphem|" xephem.c

substituteInPlace xephem.c --replace-fail '/etc/XEphem' '${placeholder "out"}/etc/XEphem'

pkgs/by-name/xe/xephem/package.nix

FliegendeWurst · 2025-01-26T10:14:21Z

pkgs/by-name/xe/xephem/package.nix

+}:
+
+stdenv.mkDerivation rec {
+  pname = "xephen";


Suggested change

pname = "xephen";

pname = "xephem";

pkgs/by-name/xe/xephem/package.nix

FliegendeWurst · 2025-01-26T10:16:31Z

pkgs/by-name/xe/xephem/package.nix

+  nativeBuildInputs = [
+    motif
+    openssl
+    groff
+    xorg.libXmu
+    xorg.libXext
+    xorg.libXt
+    copyDesktopItems
+    installShellFiles
+  ];


Suggested change

nativeBuildInputs = [

motif

openssl

groff

xorg.libXmu

xorg.libXext

xorg.libXt

copyDesktopItems

installShellFiles

];

nativeBuildInputs = [

copyDesktopItems

installShellFiles

groff # nroff

];

buildInputs = [

motif

openssl

xorg.libXmu

xorg.libXext

xorg.libXt

];

Runtime dependencies go in buildInputs.

FliegendeWurst · 2025-01-26T10:20:52Z

pkgs/by-name/xe/xephem/package.nix

+    homepage = "https://xephem.github.io/XEphem/Site/xephem.html";
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ EstebanMacanek ];
+    platforms = lib.platforms.unix;


Suggested change

platforms = lib.platforms.unix;

platforms = lib.platforms.unix;

# Makefiles hardcode unprefixed tools everywhere

broken = stdenv.buildPlatform != stdenv.hostPlatform;

Currently the package does not cross-compile, so we should mark it as such.

is there any way i can patch this?
would this help: https://nixos.org/manual/nixpkgs/stable/#cross-qa-fails-to-find-binutils?

No, you would need to replace all occurences of cc / ar / ranlib manually, since some Makefiles do not use the CC variables etc.

https://github.com/XEphem/XEphem/blob/main/libz/Makefile

FliegendeWurst · 2025-01-26T10:28:54Z

pkgs/by-name/xe/xephem/package.nix

+  ];
+
+  meta = {
+    description = "The Serious Interactive Astronomical Software Ephemeris";


Suggested change

description = "The Serious Interactive Astronomical Software Ephemeris";

description = "Serious Interactive Astronomical Software Ephemeris";

Usually description does not start with an article

FliegendeWurst · 2025-01-26T10:31:02Z

Will merge after you take care of my last round of suggestions.

FliegendeWurst · 2025-01-26T22:02:02Z

pkgs/by-name/xe/xephem/package.nix

+  checkTarget = "run-test";
+
+  makeFlags = [
+    "GCC=${stdenv.gcc.targetPrefix}gcc"


Suggested change

"GCC=${stdenv.gcc.targetPrefix}gcc"

"GCC=${stdenv.cc.targetPrefix}gcc"

The targetPrefix is actually the same for all tools and accessed via cc

FliegendeWurst · 2025-01-26T22:02:29Z

pkgs/by-name/xe/xephem/package.nix

+    "CC=${stdenv.cc.targetPrefix}cc"
+    "XLC=${stdenv.xlc.targetPrefix}xlc"
+    "NROFF=${stdenv.nroff.targetPrefix}nroff"
+    "CD=${stdenv.cd.targetPrefix}cd"


I would guess you can drop CD and RM, these do not have cross versions.

FliegendeWurst · 2025-01-26T22:02:37Z

pkgs/by-name/xe/xephem/package.nix

+    "RM=${stdenv.rm.targetPrefix}rm"
+    "AR=${stdenv.ar.targetPrefix}ar"
+    "RANLIB=${stdenv.ranlib.targetPrefix}ranlib"
+    "TOUCH=${stdenv.touch.targetPrefix}touch"


And touch too, I think.

NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 10, 2024

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/applications/science/astronomy/xephem/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/applications/science/astronomy/xephem/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/applications/science/astronomy/xephem/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/applications/science/astronomy/xephem/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/applications/science/astronomy/xephem/default.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

sikmir reviewed Mar 10, 2024

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Mar 10, 2024

EstebanMacanek force-pushed the add-xephem branch from e5a8549 to 67c6024 Compare March 13, 2024 21:51

FliegendeWurst reviewed Nov 5, 2024

View reviewed changes

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025

EstebanMacanek closed this Jan 20, 2025

EstebanMacanek reopened this Jan 20, 2025

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 20, 2025

github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 20, 2025

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 20, 2025

EstebanMacanek force-pushed the add-xephem branch 2 times, most recently from 49ccb55 to 8b23aab Compare January 20, 2025 21:04

sikmir reviewed Jan 21, 2025

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Show resolved Hide resolved

EstebanMacanek force-pushed the add-xephem branch from 8b23aab to b86a1d5 Compare January 21, 2025 12:16

FliegendeWurst reviewed Jan 21, 2025

View reviewed changes

EstebanMacanek force-pushed the add-xephem branch 2 times, most recently from fb0b9d6 to 2d446b1 Compare January 22, 2025 02:04

FliegendeWurst reviewed Jan 22, 2025

View reviewed changes

pkgs/by-name/xe/xephem/package.nix Outdated Show resolved Hide resolved

EstebanMacanek force-pushed the add-xephem branch 4 times, most recently from c107ce7 to 1f4537c Compare January 25, 2025 00:18

maintainers: add EstebanMacanek

e573e23

EstebanMacanek force-pushed the add-xephem branch 2 times, most recently from f41063b to c80eaa3 Compare January 25, 2025 20:24

FliegendeWurst reviewed Jan 26, 2025

View reviewed changes

EstebanMacanek force-pushed the add-xephem branch 3 times, most recently from 6ed8efc to 3264898 Compare January 26, 2025 18:24

xephem: init at 4.2.0

ffa6f77

EstebanMacanek force-pushed the add-xephem branch from 3264898 to ffa6f77 Compare January 26, 2025 18:30

FliegendeWurst reviewed Jan 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xephem: init at 4.2.0 #294622

xephem: init at 4.2.0 #294622

EstebanMacanek commented Mar 10, 2024 •

edited

Loading

rafameou commented Mar 13, 2024 •

edited

Loading

FliegendeWurst Nov 5, 2024

FliegendeWurst Nov 5, 2024

FliegendeWurst Jan 21, 2025

EstebanMacanek Jan 22, 2025

FliegendeWurst Jan 22, 2025

FliegendeWurst Jan 21, 2025

FliegendeWurst Jan 26, 2025

FliegendeWurst Jan 26, 2025

FliegendeWurst Jan 26, 2025

EstebanMacanek Jan 26, 2025 •

edited

Loading

FliegendeWurst Jan 26, 2025

FliegendeWurst Jan 26, 2025

FliegendeWurst commented Jan 26, 2025

FliegendeWurst Jan 26, 2025

FliegendeWurst Jan 26, 2025

FliegendeWurst Jan 26, 2025

		@@ -39617,6 +39617,7 @@ with pkgs;
		vite = libsForQt5.callPackage ../applications/science/misc/vite { };

		xearth = callPackage ../applications/science/astronomy/xearth { };

	sed -i "s\|/etc/XEphem\|$out/etc/XEphem\|" xephem.c
	substituteInPlace xephem.c --replace-fail '/etc/XEphem' '${placeholder "out"}/etc/XEphem'

	description = "The Serious Interactive Astronomical Software Ephemeris";
	description = "Serious Interactive Astronomical Software Ephemeris";

	"GCC=${stdenv.gcc.targetPrefix}gcc"
	"GCC=${stdenv.cc.targetPrefix}gcc"

xephem: init at 4.2.0 #294622

Are you sure you want to change the base?

xephem: init at 4.2.0 #294622

Conversation

EstebanMacanek commented Mar 10, 2024 • edited Loading

Description of changes

Things done

rafameou commented Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EstebanMacanek Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FliegendeWurst commented Jan 26, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EstebanMacanek commented Mar 10, 2024 •

edited

Loading

rafameou commented Mar 13, 2024 •

edited

Loading

EstebanMacanek Jan 26, 2025 •

edited

Loading