-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update socket2 in (some) packages for Rust 1.64 compatibility #194845
Conversation
If you need to run some one-off linux builds, you can ping me. Though OfBorg can do a lot, too. |
The beauty of new programming languages and distros. Gotta love it. not |
This fixes the build on Rust 1.64 since it contains an update of socket2 to a version greater than 0.3.16.
This is ready for review now. There are two remaining packages I can see are broken with this issue:
I'm not sure at this moment how much time I'll have to work on those, so I'd like to keep them separate from this. |
The MozWire part looks good to me 👍👍 |
All look OK and build for me on x86_64-linux, so let me merge relatively fast. Thanks for all the rust 1.64 fixes. |
Description of changes
Updates several packages on staging-next to use socket2 versions >= 0.3.16 so that they compile on Rust 1.64. The root cause is rust-lang/rust#78802. Related to #193494 (comment).
This leaves out several packages, either because I didn't get to them yet, I don't have a Linux machine ready for testing, or because I couldn't operate a part of the toolchain (e.g.
habitat
,hydra-cli
, etc.)For context, I am linking the PRs and issues opened upstream:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes