Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent Commits tab from disappearing #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

peterdanwan
Copy link

This is an attempt to fix #23 (previously made another pull request with the wrong issue number for the branch name).

Now, when the user navigates using the browser's back button, clicks on the repository's name, or clicks within the options within the Pull requests section, the Commits button should no longer disappear and should be accessible without a refresh.

2024-12-06.12-59-15.mp4

@NirmalScaria
Copy link
Owner

Screen.Recording.2024-12-07.at.6.40.20.AM.mov

It correctly fixes the issue with moving to "issues" page and coming back. But still fails when trying to navigate back from other pages.

  1. From discussions page, if I try to come back to le-git-graph page, the commits UI breaks. (Expands to full screen width)
  2. From actions page, if I try to come back to le-git-graph page, It doesn't work.

A more general solution is required to handle navigation altogether.

@peterdanwan
Copy link
Author

Hi @NirmalScaria, thanks for checking out what I have right now!

In addition to what you listed, I also noticed that if I visit any file or folder within the Code page, I can't navigate back to the Commits page. I'll definitely need to think over this some more to figure out why we can't navigate back to the Commits page.

On a side note - thank you for making such a cool extension! I love using git log --all --graph locally, and find it really cool that this extension lets us see all of that from GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commits tab removed when using browser's back button
2 participants