Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits tab removed when using browser's back button #23

Open
russellbanks opened this issue Nov 24, 2022 · 3 comments · May be fixed by #87
Open

Commits tab removed when using browser's back button #23

russellbanks opened this issue Nov 24, 2022 · 3 comments · May be fixed by #87
Labels
bug Something isn't working

Comments

@russellbanks
Copy link

Going into another tab on GitHub and returning (by using the Browser's back button) removes the commits tab. In some cases, the Commits tab does not get removed, but rather the button will not work anymore until the page is refreshed. This was tested on Firefox.

firefox_d29erXJv1o

@NirmalScaria NirmalScaria added the bug Something isn't working label Nov 25, 2022
@BitBlitObviMormon
Copy link

I can confirm this on Chrome. I figured it was just the website cache doing goofy things (since a hard reload fixes it).

@BitBlitObviMormon
Copy link

BitBlitObviMormon commented Feb 3, 2023

It also appears to happen when navigating around GitHub. For instance, if you view GitHub's commit history (not the extension's) and then click the "Older" button to view older commits then the extension's commit tab disappears on Chrome (Edit: This is inconsistent, sometimes it works as normal). Refreshing the page or traveling to the page directly (via url or link) appears to work around this issue.

@NirmalScaria
Copy link
Owner

Honestly I have zero idea why this happens. And I guess this has more to do with the original GitHub page code rather than the extension code. And considering how simply refreshing the page will fix the issue temporarily, I'm thinking about postponing this issue, unless someone would like to step in. Not exactly "wont-fix". Not "under-progress" either.
@BitBlitObviMormon @russellbanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants