Combat/Core: Damage Calculator & Combat Log support #324
+1,296
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
reviewed
Oct 10, 2020
kirmmin
force-pushed
the
damage-calculations
branch
from
98573e8
to
0717d77
Compare
kirmmin
added a commit
to kirmmin/NexusForever
that referenced
this pull request
Oct 12, 2020
Base damage methods added to DamageCalculator CombatResult calculations added Armor mitigation calculations CombatLogs support Use Any() instead of Count() Fix DamageCalc following merge
kirmmin
force-pushed
the
damage-calculations
branch
from
0717d77
to
769924f
Compare
Base damage methods added to DamageCalculator CombatResult calculations added Armor mitigation calculations CombatLogs support Use Any() instead of Count() Fix - Combat/DamageCalculator: Mitigation calc
kirmmin
force-pushed
the
damage-calculations
branch
from
769924f
to
7457bea
Compare
kirmmin
added a commit
to kirmmin/NexusForever
that referenced
this pull request
Mar 26, 2021
Base damage methods added to DamageCalculator CombatResult calculations added Armor mitigation calculations CombatLogs support Use Any() instead of Count() Fix DamageCalc following merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #309
I was unsure how best way to implement this in a way that was reviewable, so I settled for a separate Manager, essentially, that would be able to do the calculations and spit out the damage (as a first stab). I recognise that this does not cover every potential damage or combat calculation, but this gives a base to work with.
Some notes:
Definitely open to hearing feedback on the stat weights, diminishing returns, damage ranges, etc.