ensure we block invalid file override types (#15268)

Nexus-Mods · Feb 26, 2024 · ef306cb · ef306cb
1 parent 11efd0b
commit ef306cb
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/extensions/mod_management/reducers/mods.ts b/src/extensions/mod_management/reducers/mods.ts
@@ -173,10 +173,17 @@ export const modsReducer: IReducerSpec = {
     },
     [actions.setFileOverride as any]: (state, payload) => {
       const { gameId, modId, files }  = payload;
-
+      if (!Array.isArray(files)) {
+        // this should never happen
+        return state;
+      }
       if (state[gameId]?.[modId] === undefined) {
         return state;
       }
+      const hasInvalidEntry = files.find(file => (typeof file !== 'string')) !== undefined;
+      if (hasInvalidEntry) {
+        return state;
+      }
 
       return setSafe(state, [gameId, modId, 'fileOverrides'], files);
     },