Fix for empty transactions + Some read benchmarks #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow we no longer advance the TxId if no datoms were inserted as part of the tx. Also includes some read benchmarks I was working on
halgari
commented
Oct 24, 2024
| @@ -308,7 +309,7 @@ private StoreResult Log(IInternalTxFunctionImpl pendingTransaction) | |||
|
|
|||
| return new StoreResult | |||
| { | |||
| AssignedTxId = _thisTx, | |||
| AssignedTxId = _asOfTx, | |||
There was a problem hiding this comment.
This is the source of the bug, when we had an empty transaction (and we do anytime we reboot the app and the schema doesn't update), then we were incrementing the TxId. The internal functions increment the _asOfTx so we no longer need to use _thisTx.
erri120
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the dead UI bug we had issues with