0.9.95 - fix timestamp regression

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Changelog
 
+### 0.9.95 - 30/10/2024
+* Fix a regression with the switch to DateTimeOffset, we now store the correct timestamp in transaction attributes
+* 
 ### 0.9.94 - 30/10/2024
 * Fix a regression in the GlobalCompare that was boxing an enum (resulting in a lot of allocations)
 

src/NexusMods.MnemonicDB/Storage/DatomStore.cs

@@ -391,7 +391,7 @@ internal void LogDatoms<TSource>(IWriteBatch batch, TSource datoms,  bool advanc
     /// <exception cref="NotImplementedException"></exception>
     private void LogTx(IWriteBatch batch)
     {
-        MemoryMarshal.Write(_txScratchSpace.Span, _timeProvider.GetTimestamp());
+        MemoryMarshal.Write(_txScratchSpace.Span, _timeProvider.GetUtcNow().ToUnixTimeMilliseconds());
         var id = EntityId.From(_thisTx.Value);
         var keyPrefix = new KeyPrefix(id, AttributeCache.GetAttributeId(MnemonicDB.Abstractions.BuiltInEntities.Transaction.Timestamp.Id), _thisTx, false, ValueTag.Int64);
         var datom = new Datom(keyPrefix, _txScratchSpace[..sizeof(long)]);

tests/NexusMods.MnemonicDB.Tests/DbTests.cs

@@ -234,6 +234,27 @@ await VerifyTable(updateDatom)
         }
     }
 
+    [Fact]
+    public async Task TimestampsArentBorked()
+    {
+        using var tx = Connection.BeginTransaction();
+        var loadout = new Loadout.New(tx)
+        {
+            Name = "Test Loadout"
+        };
+
+        var result = await tx.Commit();
+
+        var recentTimestamp = result.Db.RecentlyAdded
+            .Resolved(Connection)
+            .First(d => d.A == Transaction.Timestamp);
+
+        recentTimestamp.ObjectValue.Should().BeOfType<DateTimeOffset>();
+        ((DateTimeOffset)recentTimestamp.ObjectValue).Should()
+            .BeAfter(DateTimeOffset.UtcNow.AddSeconds(-100))
+            .And.BeBefore(DateTimeOffset.UtcNow.AddSeconds(100));
+    }
+
     [Fact]
     public async Task CanGetChildEntities()
     {