Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert fix for SpatialSeries.bounds #1996

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 18, 2024

Motivation

Fix #1992

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor Author

rly commented Nov 18, 2024

Because we reverted commits in nwb-schema, the order of adding pynwb support for changes in nwb-schema 2.8.0 is no longer straightforward (and may not even be possible to not have issues). I will merge this and the other schema 2.8.0 PyNWB PRs into the nwb_schema_2.8.0 branch and look at what issues, if any, remain.

@rly rly merged commit f05027e into nwb_schema_2.8.0 Nov 18, 2024
3 of 21 checks passed
@rly rly deleted the revert_spatial_series_bounds branch November 18, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant