-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NWBHDF5IO.read_nwb() method #1979
add NWBHDF5IO.read_nwb() method #1979
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1979 +/- ##
==========================================
+ Coverage 91.87% 91.92% +0.04%
==========================================
Files 27 27
Lines 2697 2713 +16
Branches 704 708 +4
==========================================
+ Hits 2478 2494 +16
Misses 145 145
Partials 74 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, that should be fine
I think we should probably use If installed, we could also use @bendichter what would you suggest for this? |
Aside from adding s3 and testing, the outline you started here looks good to me. |
OK, I added s3 testing. |
Seems like it was a codecov issue with detecting forks, perhaps when commits happen in quick succession: codecov/codecov-action#1580 . I re-ran the failing runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the codecov question, this looks good to me. I approve the PR, because I assume the codecov question can probably be resolved in the comment, rather than requiring additional code changes, and it seems easier for me to re-approve if there are changes, rather than holding up the PR.
This was discussed in #1974
This is the first part of the program described by @oruebel here. In a future PR and once hdmf-dev/hdmf-zarr#225 is merged I will implement
pynwb.read_nwb
in another PR.Meanwhile, I have two questions:
Checklist
ruff check . && codespell
from the source directory.