Add possibility to load and dump data with superuser access #129

KhaledBousrih · 2022-04-21T12:28:56Z

lcognat · 2022-05-16T15:58:52Z

concrete_datastore/concrete/templates/admin/index.html

-<br>
-{% endif %}
+    {% if use_core_automation %}
+        <p class="custom-btn" onclick="window.location.href='{{target_admin_view}}';">Go to {{target_admin_view_name}}</p>


use a <a href= here

lcognat · 2022-05-16T15:59:16Z

concrete_datastore/concrete/templates/admin/index.html

+            };
+            function donwloadDump() {
+                document.location.href="{% url 'concrete:dump_data' %}?download=true";
+                alert('Your download will begin soon')


do not use alert

lcognat · 2022-06-13T18:52:16Z

concrete_datastore/concrete/urls.py

@@ -26,3 +29,8 @@
        name='unsubscribe_notifications_result',
    ),
 ]
+
+if settings.ENABLE_DATABASE_DUMP:
+    urlpatterns.append(re_path(r'dump-data', dump_data, name="dump_data"))


url names are not dash cased ?

Both ways are used in the project.

in concrete_datastore.api.v1_1.urls we use the method get_dashed_case_class_name that returns dash-cased names (example: my-model)

in concrete_datastore.routes.urls we also use dash-cased names (example service-status-view)

in concrete_datastore.concerte.urls we use snake-case names (exemple unsubscribe_notifications_result)

Since the code added is in the module concrete_datastore.concerte.urls I tried to keep the same naming convention of this module.

Should we homogenize the names of all the urls into dash-cased names ?

lcognat · 2022-06-13T18:53:00Z

concrete_datastore/concrete/views.py

+            status=200,
+        )
+    except Exception as e:
+        return JsonResponse(data={'error': str(e)}, status=400)


a log is required here

lcognat · 2022-06-13T18:53:51Z

concrete_datastore/concrete/views.py

+
+        json_resp = json.loads(resp_value)
+        return JsonResponse(
+            data={'result': json_resp, 'objects_count': len(json_resp)},


results would be better

lcognat · 2022-06-13T18:58:03Z

concrete_datastore/concrete/views.py

+            response = JsonResponse(data={'message': resp_value}, status=200)
+    except Exception as e:
+        response = JsonResponse(
+            data={'error': f'An error has occured: {e}'}, status=400


should be homogeneous with line 166

lcognat · 2022-06-13T18:59:21Z

concrete_datastore/routes/views.py

@@ -70,9 +71,20 @@ class DatamodelServer(APIView, TemplateView):
    )

    def _get_datamodel_format(self, data_format='yaml'):


move this to a 'datamodel' module

lcognat · 2022-06-13T19:00:18Z

concrete_datastore/routes/views.py

+            if type(value) == datetime.datetime:
+                return format_datetime(value)
+            return str(value)
+
        datamodel_content_json = settings.META_MODEL_DEFINITIONS
        if data_format == 'json':


too light about data_format validation

lcognat · 2022-06-13T19:01:54Z

concrete_datastore/routes/views.py

@@ -103,12 +115,14 @@ def get(self, request, *args, **kwargs):

    def get_context_data(self, **kwargs):
        context = super().get_context_data(**kwargs)
-        datamodel_content_json = settings.META_MODEL_DEFINITIONS
-        context['json_content'] = json.dumps(datamodel_content_json, indent=2)
+        datamodel_content_json = self._get_datamodel_format(data_format='json')
        datamodel_content_yml = self._get_datamodel_format()


specify format here

lcognat · 2022-06-13T19:03:52Z

concrete_datastore/routes/views.py

-        content = DatamodelYamlToHtml(datamodel_content_json, indent=2)
+        content = DatamodelYamlToHtml(
+            settings.META_MODEL_DEFINITIONS, indent=2
+        )
        context['yaml_displayed_content'] = content.render_yaml()


class is named Yaml to Html, but only function "render yaml" is called, a yaml is expected as a result.
So based on the class name "YAML to HTML", but based on parameters and function names "JSON to YAML" ?

…dumpdata

lcognat · 2023-03-31T14:38:02Z

concrete_datastore/concrete/templates/admin/index.html

                document.location.href="{% url 'concrete:dump_data' %}?download=true";
-                alert('Your download will begin soon')
+                setInterval(()=>{console.log(test)}, 1000)
+                // hideWaitingDiv();


Should delete this line if obsolete, or uncomment ?

KhaledBousrih added 5 commits September 14, 2021 10:27

Add possibility to load and dump data

a05cbb6

Add possibility to load and dump data with superuser access

f9bd73d

resolve colflicts

3a52f95

fix style

522014f

typo

0083f1f

KhaledBousrih requested review from lcognat and Souleymane-T April 21, 2022 12:28

KhaledBousrih assigned lcognat Apr 21, 2022

fix use of named temporary file

b1d74cd

lcognat requested changes Jun 13, 2022

View reviewed changes

KhaledBousrih added 2 commits June 14, 2022 11:16

Merge remote-tracking branch 'upstream/master' into feature-loaddata-…

562a552

…dumpdata

Merge remote-tracking branch 'upstream/master' into feature-loaddata-…

c28ae31

…dumpdata

KhaledBousrih marked this pull request as draft October 19, 2022 13:28

fix templates

ba436f3

lcognat requested changes Mar 31, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add possibility to load and dump data with superuser access #129

Add possibility to load and dump data with superuser access #129

KhaledBousrih commented Apr 21, 2022

lcognat May 16, 2022

lcognat May 16, 2022

lcognat Jun 13, 2022

KhaledBousrih Jun 24, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Jun 13, 2022

lcognat Mar 31, 2023

		@@ -70,9 +71,20 @@ class DatamodelServer(APIView, TemplateView):
		)

		def _get_datamodel_format(self, data_format='yaml'):

Add possibility to load and dump data with superuser access #129

Are you sure you want to change the base?

Add possibility to load and dump data with superuser access #129

Conversation

KhaledBousrih commented Apr 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment