Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pending block case in traceTransaction method #1833

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Apr 22, 2024

Issue #1794

rpc/handlers.go Outdated Show resolved Hide resolved
rpc/handlers.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.01%. Comparing base (c04fa8e) to head (237f41e).

Files Patch % Lines
rpc/trace.go 69.23% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   74.46%   75.01%   +0.55%     
==========================================
  Files          96       96              
  Lines        8177     8186       +9     
==========================================
+ Hits         6089     6141      +52     
+ Misses       1568     1518      -50     
- Partials      520      527       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kirugan kirugan merged commit a9f794f into main Apr 23, 2024
14 of 15 checks passed
@kirugan kirugan deleted the kirugan/trace-tx-in-pending-block branch April 23, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants