Remove redundant agent graceful restart #704
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent no longer needs a restart during module updates since its configuration is no longer dependent on the module itself. A restart is only required during core updates.
I noticed SIGUSR1 runs multiple times during core-update if core and Loki (for example) are updated together.
The removed lines were originally added in this commit a90baa3.
When SIGUSR1 is caught, the agent stops running new tasks until the currently running ones finish. This can lead to deadlocks if a running task enqueues a new subtask and waits for it. I think we need to modify the current behavior to prevent these deadlocks (in another PR).
Refs NethServer/dev#7016