-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'node_id' attribute to core modules #691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add node label, if present? In NS8 UI, a node is usually named:
- "My first node (Node 1)" if node label is present
- "Node 1" if node label is not present
If this change makes sense, I also suggest to rename "Node ID" column to to "Node"
do you mean to display in the column instead of |
Yes, or display "My node (Node 1)" if the node has a label "My node" set |
You can use getNodeLabel() function from ns8-ui-lib |
I need to share with @DavidePrincipi, I am not sure it is in the scope, the goal is to sort by node ID, and any verbose label could break it |
NsDataTable component supports custom sorting with |
Not really. The important thing is to sort by the Node column, so that components on the same node are grouped together. An alphabetical sort should work too! |
Co-authored-by: Davide Principi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor fixes. Reminder: let's ensure UI code is formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library change LGTM
This pull request adds the 'node_id' attribute to the core modules in the codebase. The 'node_id' attribute is used to identify the node where the module is installed. This change ensures that the 'node_id' is included in the core module list and is displayed in the software center UI.
NethServer/dev#6989