App instances count as available applications #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first item of installed modules and versions arrays are certainly the latest available. Installed modules are sorted by version number, like versions available from remote repositories.
Even if all repositories are disabled, consider installed instances as a repository itself and return synthesized metadata from list_available(). An installed application is always properly covered by its metadata.json and image labels as fallback, in case a remote repository does not list it any more.
The list is built starting from installed instances (instead of comparing available instances from repositories to what is installed). This is necessary to always capture the "core" module as installed.
The notice should contain the app/instance name to help fixing the missing logo. |
stephdl
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if there is no repository enabled I want to see Apps in the Software Center, and Core components too.
This PR changes the list_available() return value, to include those instances that do not belong to any repository (orphans).
Metadata (logo image included) of orphan apps is synthesized from the metadata.json and .png image installed in the cluster leader, if present. Also the image labels are retrieved from the leader image store.
The list_available function is called from many code points. It affects the results of the following actions, without impact on the output format:
list-moduleslist-installed-moduleslist-core-moduleslist-updatesupdate-modules(invoked also by apply-updates command)The ordering of available versions and installed versions has been implemented from newest to oldest.
Refs NethServer/dev#6947