Update SetFqdnModal labels for hostname and domain creation #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
either we add a new string in the json file init.domain and init.hostname or we decide to reuse the init.domain_create and init.hostname_create like I did other way we could decide that this panel cannot use the init.* in the json file and it deserves its own translation |
DavidePrincipi
requested review from
andre8244
and removed request for
DavidePrincipi
andre8244
approved these changes
May 24, 2024
|
Found the commit that caused the translation error: 6cb07ee |
|
what do you think it could be the better approach @andre8244 ? |
This PR is ok, already approved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the labels for the hostname and domain fields in the SetFqdnModal component. The labels were changed to "init.hostname_create" and "init.domain_create" respectively. This change improves the clarity and accuracy of the labels in the user interface.
NethServer/dev#6927