Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: limit argo workflow name length #1608

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Oct 23, 2023

first draft for fixing argo workflows workflow name maxLength. Previously 253 characters have been allowed, but this causes launching workflows through Argo UI to fail for names longer than 63 characters, as Argo wants to set the workflow template name as a Kubernetes label for the workflow.

Idea is to introduce a new limit of 63 characters, which checks for existence of a >63char deployment upon name resolving and raises an exception in case one is found. User can circumvent this by applying a flag to use the old name lengths for argo workflow commands:

argo-workflows --old-name-length [command]

Note: This can in some cases affect GitOps setups and other CI solutions for deploying flows. An easy workaround for those would to apply the --old-name-length flag for deployments to retain the original functionality.

attempts to address #1521 and unblock implementing #1416

@saikonen
Copy link
Collaborator Author

  • requires some guard against truncating project flows to invalid DNS subdomain names (dot followed by dash)
  • possibly rethink how project flows are truncated (visibility: project part vs. flow name). we could opt for truncating the project part and keeping flow name visible instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant