Refactor: Update build.gradle and fix import order in SelJodaDateTimePropertyTest to pass Spotless check #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the developer's computer environment is not set to English, running Unit Tests may result in errors.
…opertyTest - Adjusted the order of imports to comply with Spotless formatting rules. - Ran `./gradlew :netflix-sel:spotlessApply` to automatically fix format violations.
jun-he
reviewed
Jul 26, 2024
build.gradle
Outdated
| @@ -39,7 +39,7 @@ allprojects { | |||
| } | |||
|
|
|||
| test { | |||
| jvmArgs += ["-Djava.security.manager=allow"] | |||
| jvmArgs += ["-Djava.security.manager=allow", "-Duser.language=en", "-Duser.country=US"] | |||
There was a problem hiding this comment.
Wondering if country is required?
|
If your application works correctly without -Duser.country=US, then specifying the country is not mandatory. However, if your application relies on specific locale settings (such as date and currency formats), it is better to explicitly specify the country. To ensure consistent behavior, it is advisable to set both the language and the country. |
|
@HankGuo93 can you remove the change in test jvmArgs from this PR and I can merge the other change about the |
- Removed "-Duser.language=en" and "-Duser.country=US"
|
I've removed the changes to the test JVM arguments. The PR now only includes the import changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
chore: Update build.gradle
fix: Correct import order to pass Spotless check in SelJodaDateTimePropertyTest
./gradlew :netflix-sel:spotlessApplyto automatically fix format violations.