chore: remove Joda-Time dependency from maestro-common #25 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed Joda-Time dependency from the Defaults class and replaced it with java.time.ZoneId. - Updated TriggerHelper class to use java.time.ZoneId instead of Joda-Time's DateTimeZone. - Simplified TimeZoneValidator to use a static final set of available time zone IDs, ensuring efficient validation.
pranaybattu
force-pushed
the
issue-25/remove-joda-time
branch
from
fc7622c
to
fc931cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
This pull request removes the Joda-Time dependency #25 from the
maestro-commonmodule and replaces it with thejava.timeAPI. The changes include:Defaultsclass and replaced it withjava.time.ZoneId.TriggerHelperclass to usejava.time.ZoneIdinstead of Joda-Time'sDateTimeZone.TimeZoneValidatorto use a static final set of available time zone IDs, ensuring efficient validation.This change modernizes the codebase by adopting the java.time API, which is the recommended approach for handling date and time in Java 8 and later versions. The updates ensure that time zone handling is consistent and efficient