Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jackson to 2.15.4 #17

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

varunu28
Copy link
Contributor

@varunu28 varunu28 commented Jul 22, 2024

This addresses #10 .

Doing an incremental upgrade from the current version i.e. 2.11.4 , the latest version at which build is successful is 2.15.4

https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-core

Upgrading to the next version i.e. 2.16.0 results in test failures with below error log:

Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 optional type `java.util.Optional<com.netflix.conductor.common.metadata.tasks.TaskDef>` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jdk8" to enable handling (through reference chain: com.netflix.conductor.common.metadata.tasks.Task["taskDefinition"])
	at app//com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:77)
	at app//com.fasterxml.jackson.databind.SerializerProvider.reportBadDefinition(SerializerProvider.java:1330)
	at app//com.fasterxml.jackson.databind.ser.impl.UnsupportedTypeSerializer.serialize(UnsupportedTypeSerializer.java:35)
	at app//com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:732)
	at app//com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:770)
	at app//com.fasterxml.jackson.databind.ser.BeanSerializer.serialize(BeanSerializer.java:183)
	at app//com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:502)
	at app//com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:341)
	at app//com.fasterxml.jackson.databind.ObjectMapper._writeValueAndClose(ObjectMapper.java:4793)
	at app//com.fasterxml.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:4038)
	at app//com.netflix.conductor.cockroachdb.dao.CockroachDBBaseDAO.toJson(CockroachDBBaseDAO.java:158)

@varunu28
Copy link
Contributor Author

varunu28 commented Jul 22, 2024

@jun-he Can you please review this change? Thank you 👍

@jun-he
Copy link
Contributor

jun-he commented Jul 22, 2024

@varunu28 thanks for the contribution! I will review it ASAP.

@@ -46,8 +46,8 @@ allprojects {
resolutionStrategy {
// Force 2.11.4 until upgrade is done
// Jackson is to be locked due to conversion issue with Double<>BigDecimal
force "com.fasterxml.jackson.core:jackson-databind:2.11.4"
force "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.11.4"
force "com.fasterxml.jackson.core:jackson-databind:2.15.4"
Copy link
Contributor

@jun-he jun-he Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to remove the pin here. But the dependency of conductor might block it. There is an ongoing effort to remove the conductor from the Maestro (#5).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Removing the pin results in the same error as described in the description for following tests
image

@varunu28 varunu28 requested a review from jun-he July 23, 2024 13:40
Copy link
Contributor

@jun-he jun-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @varunu28 for the change. I think this incremental upgrade is better than the current pin to 2.11.4. I will run some tests on the workflow data to see if there is any serde or conversion issue.

@varunu28 varunu28 requested a review from jun-he July 30, 2024 16:02
@jun-he
Copy link
Contributor

jun-he commented Jul 30, 2024

@varunu28 doing the load test right now and will get back to you soon.

@jun-he
Copy link
Contributor

jun-he commented Aug 1, 2024

Load test is done and the change looks good.
@varunu28 can you rebase the PR and then rerun the write-lock to update the dependencies? Thanks.

@varunu28
Copy link
Contributor Author

varunu28 commented Aug 2, 2024

@jun-he I ran the write-lock. Can you please do another review?

Copy link
Contributor

@jun-he jun-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. LGTM.

@jun-he jun-he merged commit f2672dd into Netflix:main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants