Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement touch to stop speech #69

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

Irineu333
Copy link
Member

Description

Following the behavior of Talkback and Jieshou, Speak Touch should stop speech when the user touches the screen.

Improvements

Resolves #66

  • Stop speech when user touches the screen

@Irineu333 Irineu333 added the feature New feature or request label Oct 2, 2023
@Irineu333 Irineu333 added this to the MVP milestone Oct 2, 2023
@Irineu333 Irineu333 requested a review from PatrykMis October 2, 2023 02:58
@Irineu333 Irineu333 self-assigned this Oct 2, 2023
@Irineu333 Irineu333 linked an issue Oct 2, 2023 that may be closed by this pull request
@Irineu333 Irineu333 changed the base branch from main to develop October 2, 2023 02:58
@Irineu333 Irineu333 force-pushed the feature/ISSUE#66-implement-stop-reading branch from 3b09481 to 791fe72 Compare October 2, 2023 03:01
@Irineu333 Irineu333 force-pushed the feature/ISSUE#66-implement-stop-reading branch from 791fe72 to 2de2a95 Compare October 2, 2023 14:27
Copy link
Collaborator

@PatrykMis PatrykMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't support resuming, but works great!

@Irineu333
Copy link
Member Author

Irineu333 commented Oct 19, 2023

Very observant, @PatrykMis, I noticed that, tried to solve it, but the solution is not simple, so I created this issue #71, and also #70.

@Irineu333 Irineu333 merged commit cfb72a8 into develop Oct 19, 2023
1 check passed
@Irineu333 Irineu333 deleted the feature/ISSUE#66-implement-stop-reading branch October 19, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement touch to stop speech
2 participants