Deep children check #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irineu333
force-pushed
the
bugfix/wrong-children-check
branch
from
86d6588 to
d2141ac
Compare
Irineu333
force-pushed
the
bugfix/wrong-children-check
branch
from
d2141ac to
4a9217c
Compare
This was
linked to
issues
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
isReadableAsChildfunction was not checking its children recursively. This function is used to find out if aViewcan be read as a child of aViewGroup. Generally this occurs when theViewGroupitself does not have acontentDescriptionor any intrinsic content to be read, the app then loops through its children, but not all children can be read, children that must be read directly (another rule) must not be read. read as children of other elements, I deduced this logic by testing Talkback and Jieshou, but I didn't code it correctly, but now it's corrected..Fixed issues
Fixes #67
Fixes #48