Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App is focusing on non-readable ViewGroup #54

Merged
merged 6 commits into from
Sep 30, 2023
Merged

App is focusing on non-readable ViewGroup #54

merged 6 commits into from
Sep 30, 2023

Conversation

Irineu333
Copy link
Member

@Irineu333 Irineu333 commented Sep 28, 2023 •
edited
Loading

Fixes #53

Fix

Fixed bug in the commit bbc37ce, hasReadableChild function of NodeValidator was coded wrong

Refactor

  • Documented the functions of NodeValidator
  • Improved the isRequiredFocus function

@Irineu333 Irineu333 added the bug Something isn't working label Sep 28, 2023
@Irineu333 Irineu333 added this to the MVP milestone Sep 28, 2023
@Irineu333 Irineu333 requested a review from PatrykMis September 28, 2023 08:10
@Irineu333 Irineu333 self-assigned this Sep 28, 2023
@Irineu333 Irineu333 added documentation Improvements or additions to documentation refactor Improvement without changing behavior labels Sep 28, 2023
@Irineu333 Irineu333 changed the title App is focusing on non readable viewgroup [ISSUE-53] App is focusing on non readable viewgroup Sep 28, 2023
@Irineu333 Irineu333 changed the title [ISSUE-53] App is focusing on non readable viewgroup App is focusing on non readable viewgroup Sep 28, 2023
@Irineu333 Irineu333 changed the title App is focusing on non readable viewgroup App is focusing on non readable ViewGroup Sep 28, 2023
@Irineu333 Irineu333 changed the title App is focusing on non readable ViewGroup App is focusing on non-readable ViewGroup Sep 28, 2023
@Irineu333 Irineu333 linked an issue Sep 29, 2023 that may be closed by this pull request
App is focusing on non-readable ViewGroup #53
Closed
@Irineu333 Irineu333 merged commit af94819 into develop Sep 30, 2023
1 check passed
@Irineu333 Irineu333 deleted the bugfix/ISSUE53-app-is-focusing-on-non-readable-viewgroup branch September 30, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykMis PatrykMis Awaiting requested review from PatrykMis

Assignees

@Irineu333 Irineu333

Labels
bug Something isn't working documentation Improvements or additions to documentation refactor Improvement without changing behavior
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

App is focusing on non-readable ViewGroup
1 participant
@Irineu333