Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read empty edit text #114

Merged
merged 9 commits into from
Nov 27, 2023
Merged

Read empty edit text #114

merged 9 commits into from
Nov 27, 2023

Conversation

Irineu333
Copy link
Member

@Irineu333 Irineu333 commented Nov 25, 2023 •
edited
Loading

Description

As described in the issue, an edit field should always be read.

Improvements

  • Consider editable as readable content

Fixed issues

  • App wasn't announcing empty fields

@Irineu333 Irineu333 added the bug Something isn't working label Nov 25, 2023
@Irineu333 Irineu333 added this to the MVP milestone Nov 25, 2023
@Irineu333 Irineu333 requested a review from PatrykMis November 25, 2023 21:51
@Irineu333 Irineu333 self-assigned this Nov 25, 2023
@Irineu333 Irineu333 linked an issue Nov 25, 2023 that may be closed by this pull request
Empty edit fields without content are not being announced #109
Closed
@Irineu333 Irineu333 changed the title Bugfix/issue#109 read empty edit text Read empty edit text Nov 25, 2023
PatrykMis
PatrykMis approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@PatrykMis PatrykMis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works and looks good.

@Irineu333 Irineu333 force-pushed the bugfix/ISSUE#109-read-empty-edit-text branch from 9d2624c to 2d43174 Compare November 27, 2023 17:05
@Irineu333 Irineu333 added the easy Lower difficulty issue label Nov 27, 2023
@Irineu333 Irineu333 merged commit df538c5 into develop Nov 27, 2023
1 check passed
@Irineu333 Irineu333 deleted the bugfix/ISSUE#109-read-empty-edit-text branch November 27, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrykMis PatrykMis PatrykMis approved these changes

Assignees

@Irineu333 Irineu333

Labels
bug Something isn't working easy Lower difficulty issue
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Empty edit fields without content are not being announced
2 participants
@Irineu333 @PatrykMis