Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Reader class #100

Merged
merged 15 commits into from
Nov 30, 2023
Merged

Improve Reader class #100

merged 15 commits into from
Nov 30, 2023

Conversation

PatrykMis
Copy link
Collaborator

@PatrykMis PatrykMis commented Nov 8, 2023 •
edited by Irineu333
Loading

Improvements

  • SpeakTouch now reads statusses of various controlls according to their roles.

Fixed issues

  • CheckedText was not announced as checked if checked

Other

@PatrykMis PatrykMis added the feature New feature or request label Nov 8, 2023
@PatrykMis PatrykMis added this to the MVP milestone Nov 8, 2023
@PatrykMis PatrykMis requested a review from Irineu333 November 8, 2023 14:04
@PatrykMis PatrykMis self-assigned this Nov 8, 2023
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch 3 times, most recently from fdf4967 to 1054b21 Compare November 8, 2023 15:08
@PatrykMis PatrykMis changed the title Reader class workarround (partially resolves #97) Improve Reader class Nov 9, 2023
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch from 666dc83 to 6ed5cd4 Compare November 9, 2023 00:49
@Irineu333 Irineu333 force-pushed the feature/ISSUE#35-implement-exploration-gestures branch from d9a5768 to c545af1 Compare November 9, 2023 04:19
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch 2 times, most recently from 625edcf to 9e1c021 Compare November 9, 2023 23:54
Base automatically changed from feature/ISSUE#35-implement-exploration-gestures to develop November 14, 2023 04:47
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch from 9e1c021 to ef5c925 Compare November 14, 2023 13:31
@Irineu333 Irineu333 mentioned this pull request Nov 17, 2023
Merged
@Irineu333 Irineu333 linked an issue Nov 27, 2023 that may be closed by this pull request
Improve Reader class #97
Closed
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch 3 times, most recently from 956649b to 3bb9d58 Compare November 30, 2023 03:38
Irineu333
Irineu333 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Irineu333 Irineu333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply gorgeous

@Irineu333 Irineu333 added refactor Improvement without changing behavior and removed refactor Improvement without changing behavior labels Nov 30, 2023
@PatrykMis PatrykMis force-pushed the feature/ISSUE#97-improve-reader-class branch from 840f63f to 5f71238 Compare November 30, 2023 04:09
@Irineu333 Irineu333 added refactor Improvement without changing behavior and removed feature New feature or request labels Nov 30, 2023
@PatrykMis PatrykMis merged commit d5f2ad3 into develop Nov 30, 2023
2 checks passed
@PatrykMis PatrykMis deleted the feature/ISSUE#97-improve-reader-class branch November 30, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irineu333 Irineu333 Irineu333 approved these changes

Assignees

@PatrykMis PatrykMis

Labels
refactor Improvement without changing behavior
Projects
None yet
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

Improve Reader class
2 participants
@PatrykMis @Irineu333