Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow plugins to use widgets lib #5377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

farfromrefug
Copy link
Contributor

I have plugins that use classes from the nativescript widget libs.
Now i want to publish the plugin with the java sources directly.
If i do that i need to add widget-release to the dependencies.

Now i could do that in the plugin include.gradle, it will make plugin build to work however then app building wont work because the widgets lib will be included twice

So the best solution is automatically add it here.
I am not happy about the path thing, however it will work in all cases.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

I have plugins that use classes from the nativescript widget libs.
Now i want to publish the plugin with the java sources directly.
If i do that i need to add `widget-release` to the dependencies.

Now i could do that in the plugin include.gradle, it will make plugin build to work however then app building wont work because the widgets lib will be included twice

So the best solution is automatically add it here.
I am not happy about the path thing, however it will work in all cases.
@project-bot project-bot bot added this to Pull Request in CLI Team Sep 6, 2020
@cla-bot cla-bot bot added the cla: yes label Sep 6, 2020
@farfromrefug
Copy link
Contributor Author

Ok so actually find a way to declare the dependency without needing this.
Anyway that might get useful.
Let me know if you still want that PR

@janoshrubos
Copy link
Contributor

@triniwiz do you see anything wrong with this change? (i.e. increased apk size, etc..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
CLI Team
  
Pull Request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants