Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove reference in NPS config to old Webpack package, and add reference to Webpack 5 unit tests. #10526

Merged
merged 2 commits into from May 1, 2024

Conversation

apburgess
Copy link
Contributor

PR Checklist

What is the current behavior?

Using 'npm start' (as in the documentation) shows a menu where you can pick from the various project build scripts and unit tests. This menu still contains reference to the old Webpack package, and launching either of the options associated with it gives an error. There is also no menu option to invoke the Webpack5 unit tests.

What is the new behavior?

Removes the references to the old Webpack package from the NPS config file, and adds a reference to invoke the unit testing for the Webpack5 package.

Fixes/Implements/Closes #[Issue Number].

@cla-bot cla-bot bot added the cla: yes label Apr 23, 2024
Copy link

@SeanKelly369 SeanKelly369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyone still using webpack 4 or older at this stage shouldn't be.

@rigor789 rigor789 merged commit a91bb7d into NativeScript:main May 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants