Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(android): Background handling improvements #10451

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CatchABus
Copy link
Contributor

PR Checklist

What is the current behavior?

There are cases when android native background is not unset when background or background color is set to null.
Also, blank shadow rules seem to cause weird behavior as there can be a view with box-shadow: none by default and that view will have its default drawable removed.

Another thing that was tracked during tests is that cached drawable seems to be broken since ever because it's set to the wrong instance.
This is a continuation of #9615.

What is the new behavior?

This patch takes care of the remaining background handling problems and adds a few android-specific helper functions to get rid of deprecated setColorFilter calls and duplicate code here and there.

@cla-bot cla-bot bot added the cla: yes label Nov 29, 2023
@CatchABus CatchABus changed the title Android background improvements feat:(android): Background handling improvements Nov 30, 2023
Copy link

cla-bot bot commented Mar 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla: yes label Mar 12, 2024
@CatchABus CatchABus force-pushed the android-background-improvements branch from a8a9e6c to 9524783 Compare March 12, 2024 10:54
@cla-bot cla-bot bot added the cla: yes label Mar 12, 2024
Copy link

cla-bot bot commented Mar 15, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Dimitris - Rafail Katsampas.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla: yes label Mar 15, 2024
@CatchABus CatchABus force-pushed the android-background-improvements branch from dba175a to 747753a Compare March 15, 2024 20:11
@cla-bot cla-bot bot added the cla: yes label Mar 15, 2024
@CatchABus CatchABus marked this pull request as ready for review March 15, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant