fix(ios): Nested modals #10448
Open
fix(ios): Nested modals #10448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/core/application/index.ios.ts # packages/core/index.ts
…sublayers (NativeScript#9881)" (NativeScript#9917) This reverts commit 3d882b0.
…able textview to still be selectable
…for example to fake disabled state while allowing touch)
This will allow to test for `isLoaded` and deffer heavy operations on backStack pages
…once the view is loaded again
launchEvent is not triggered at the same moment on iOS and Android. iOS is firing after setting the rootView while Android is firing before. Consequently if you need an event for when the rootView is set (to read/write root css variables) you need such event
…instead of a `Color`
…le to access the `ns-root` class which comply with css specs (for example to read root css variables)
on iOS as the UILayoutViewController can be used for other widget we need to let it know it is for modal so that it still loads/unloads the view (there was a test for parent).
… can be instantiated within android layouts
# Conflicts: # packages/core/ui/transition/page-transition.android.ts
farfromrefug
added a commit
to nativescript-community/ui-material-components
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can now show modal on top of each other
it will even work if a dialog is showing
Screen.Recording.2023-11-24.at.11.13.10.mov