Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: additional GridLayout optimizations #10428

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

SeanKelly369
Copy link

Optimised of the gridlayout code for iOS. Use in a production app, with no breaking changes.

Copy link

cla-bot bot commented Nov 2, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sean Kelly.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@vallemar
Copy link
Contributor

vallemar commented Nov 2, 2023

@SeanKelly369 nice! Have you done any performance testing?

@SeanKelly369
Copy link
Author

I did for the app for work within a CollectionView table.

Formatting fixes
Copy link

cla-bot bot commented Nov 2, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sean Kelly.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@NathanWalker NathanWalker changed the title Feat/gridlayout optimisations perf: additional GridLayout optimizations Nov 25, 2023
@NathanWalker
Copy link
Contributor

@SeanKelly369 when possible, if you can sign the CLA as mentioned here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants