perf: improve attribute selectors by adding single listeners #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
force-pushed
the
perf/css-dynamic-props
branch
from
a077d60
to
84fd558
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for a possible performance optimization on CSS. Currently if we have multiple attributes tracked, we add 1 listener for each property. With this PR we add 1 listener and on property change we check if that property triggers a CSS change or not.
Additionally, we add a way (via
CSSUtils.IgnoredCssDynamicAttributeTracking) to ignore attributes globally. This is useful for Angular where we can ignore attributes like_ngHostand_ngCmpwhich only match and never change.Marking as a draft as this might create regressions and needs more testing.