[android] change fragment transactions

[vallemar]

This is a second attempt at this PR #8791. @farfromrefug could you check it? on my mobile it works and the flash of the maps have disappeared

[farfromrefug]

@vallemar that was fast. You don't need changes in core/application. Could you please remove them from that PR?

[vallemar]

@farfromrefug if it refers to this file packages/core/application/index.android.ts if I don't put the changes the application gives an error when opening, I haven't tried one by one. I will find which one is necessary and update the branch

[vallemar]

I have seen that they have added this to 8.4 amazing! I'm sure this needs some change, there were times it worked for me and other times it didn't, but I think it was because of how I have my local environment. I'm not going to be able to do anything for the whole weekend, I just took the pc to the technician because I think the graphics card is broken

[nx-cloud]

Nx Cloud Report

CI is running for commit 9753520.

📂 Click to track the progress, see the status, the terminal output, and the build insights.

---

Sent with 💌 from NxCloud.

[vallemar]

Guys, I'm testing @farfromrefug fork that has these changes and I have to say that I think the difference in Android when browsing is quite a bit, with the current ns-core package I lose the animation because it gets stuck when entering a page with a lot of components and with the fork the animation makes it perfect and it doesn't seem to get stuck

[farfromrefug]

@vallemar it is quite a big change. We need to test that quite a bit. Not sure what the best approach would be to ensure there is no regression. Firs nx report seems to report a tsc issue on this. @NathanWalker I dont see what command line it is failing on to reproduce locally. Can you tell me ?
@vallemar did you try that PR does it works fine for you?

[vallemar]

@farfromrefug I had it working but there were times that it had some failures to start, I don't know if it was because I changed the core in node_modules or because. On top of that, another commit has slipped in, sorry. I would have to try it again but when I try to run the core on my pc my pc crashes

[farfromrefug]

@vallemar OK if you can force push without the unwanted commit that would be great.
About your case where it fails if you can create a reproducible example I could fix it

[vallemar]

@farfromrefug Using this version my application is working perfectly and without blinking in the navigation. The only thing is that I have these two warnings and I don't know why, since the BackstackEntry type is being exported in the d.ts

WARNING in ../../../../git/NativeScript/packages/core/ui/frame/index.android.ts 516:57-71
export 'BackstackEntry' (imported as 'BackstackEntry') was not found in '.' (possible exports: Frame, FrameBase, NavigationType, _stack, actionBarVisibilityProperty, attachStateChangeListener, defaultPage, getFrameById, goBack, moduleLoaded, reloadPage, setActivityCallbacks, setFragmentCallbacks, setFragmentClass, topmost)

WARNING in ../../../../git/NativeScript/packages/core/ui/frame/index.android.ts 516:91-105
export 'BackstackEntry' (imported as 'BackstackEntry') was not found in '.' (possible exports: Frame, FrameBase, NavigationType, _stack, actionBarVisibilityProperty, attachStateChangeListener, defaultPage, getFrameById, goBack, moduleLoaded, reloadPage, setActivityCallbacks, setFragmentCallbacks, setFragmentClass, topmost)

video5843545908083428893.mp4

[farfromrefug]

@vallemar can you try to replace import { ExpandedEntry } from './fragment.transitions.android'; in with import type { ExpandedEntry } from './fragment.transitions.android'; in index.android.ts

[vallemar]

@farfromrefug this does not solve the problem, the error comes from BackstackEntry not from ExpandedEntry

[farfromrefug]

Yes but I thought it would be this. Strange I don't have the error in my fork. Need to look at this PR locally

[farfromrefug]

@vallemar i fixed the warning but i cant commit in your branch. You need to change the first line of core/ui/frame/index.android.ts with this

import { AndroidFrame as AndroidFrameDefinition, AndroidActivityCallbacks, AndroidFragmentCallbacks, NavigationTransition } from '.';
import type { BackstackEntry } from '.';

[vallemar]

@farfromrefug done! Thanks!

[vallemar]

I am using @farfromrefug fork, I am noticing that in the navigation the lottie components take a while to load (I think the lists also take longer to display). I'm not sure if it's because of these changes, because of the component itself or because of something else, I'm just leaving it here as a note to check before continuing with this

[farfromrefug]

@vallemar you need to give more context. What kind of navigation ?

[vallemar]

@farfromrefug it's a simple forward navigation, using the Fade transition, here's a video showing the delay

Screenrecorder-2023-02-12-12-58-15-973.mp4

in the En ruta button it seems to be more noticeable because it makes the button grow and with the background it is more noticeable (it is the first one that I show in the video)

[farfromrefug]

@vallemar ok would be good to create comparable example. Forward navigation should make no difference. Backward navigation should be very different though

[vallemar]

I think this should be taken up again, I am having navigation delays when using NS but I don't see them if I use the fork...