Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete duplicated code in sendProxySetup() in net.cc #1420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kais-nvidia
Copy link

The sendProxySetup() function in src/transport/net.cc has duplicated code. Although these code will not affect the function of NCCL, I think it should be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant