Fix bug with wrong instance of lib being called for load/close #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Klues <[email protected]>
The refcount is still 0 within the body of load(), making the check in LookupSymbol() think that the library isn't loaded yet while calling updateVersionedSymbols(). This change replaces calls with library.LookupSymbol() within updateVersionedSymbols() to calls of library.dl.Lookup() directly to avoid the check against refcount. Signed-off-by: Kevin Klues <[email protected]>
klueska
force-pushed
the
fix-bug-load-close
branch
from
31312e5 to
73ee14c
Compare
elezar
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, go-nvlib is broken, when looking up symbol names, for example. Also, no v2 or v3 symbols are loaded as expected which breaks, for example,
GetGpuInstancePossiblePlacements()for the extended media types.