Remove need for newDynamicLibraryFunc #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Apr 4, 2024
| } | ||
|
|
||
| libnvml.dl = dl.New(o.path, o.flags) |
There was a problem hiding this comment.
Note that libnvml still has a path member. Should we set that to o.path here too?
There was a problem hiding this comment.
Yes. Ideally we would drop it, but it's used in error messages and there is no way to pull it out of the dl field since it is an interface and not a concrete type.
elezar
reviewed
Apr 4, 2024
| newDynamicLibrary: func(path string, flags int) dynamicLibrary { | ||
| return dl.New(path, flags) | ||
| }, | ||
| path: defaultNvmlLibraryName, |
There was a problem hiding this comment.
Question about the path member below.
With the introduction of the refcount we no longer need to set library.dl to nil to track when it is loaded or unloaded. Instead we can use the refcount directly. Signed-off-by: Kevin Klues <[email protected]>
elezar
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the refcount we no longer need to set library.dl to nil to track when it is loaded or unloaded. Instead we can use the refcount directly.