Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure uccsd from cudaqx compiles for quantum devices #2458

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make sure uccsd from cudaqx compiles for quantum devices #2458

wants to merge 5 commits into from

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Dec 9, 2024 •
edited
Loading

Description

Fix a number of issues with compiler passes discovered in uccsd compilation for quantum devices.

Details

  • Fix crashes in LiftArrayAlloc
  • Add const prop for if(%true) and if(%false) statements
  • Unroll loops twice in the unrolling pipeline, with the LiftArrayAlloc pass in between
    • helps const prop loop boundaries stored in arrays
  • Use solvers.stateprep.uccsd code
  • Add tests

@annagrin
Temp
00aa8d8 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merged with main
1a300ba 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Add tests
b1b220c 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into fi…
0ca3674 
…x-for-demo

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Revert temp changes
fac55bd 
Signed-off-by: Anna Gringauze <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@cuda-quantum-bot
Docs preview for PR #2458.
1ca1476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi

@amccaskey amccaskey Awaiting requested review from amccaskey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@annagrin