Fix failing NVQC integration tests #2300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Gringauze <[email protected]>
bmhowe23
reviewed
Oct 18, 2024
| @@ -181,7 +181,7 @@ do | |||
| # Skipped long-running tests (variational optimization loops) for the "remote-mqpu" target to keep CI runtime managable. | |||
| # A simplified test for these use cases is included in the 'test/Remote-Sim/' test suite. | |||
| # Skipped tests that require passing kernel callables to entry-point kernels for the "remote-mqpu" target. | |||
| if [[ "$ex" == *"vqe_h2"* || "$ex" == *"qaoa_maxcut"* || "$ex" == *"gradients"* || "$ex" == *"grover"* || "$ex" == *"multi_controlled_operations"* || "$ex" == *"phase_estimation"* || "$ex" == *"trotter_kernel_mode"* || "$ex" == *"builder.cpp"* ]]; | |||
| if [[ "$ex" == *"vqe_h2"* || "$ex" == *"qaoa_maxcut"* || "$ex" == *"gradients"* || "$ex" == *"grover"* || "$ex" == *"multi_controlled_operations"* || "$ex" == *"phase_estimation"* || "$ex" == *"building_kernels"* || "$ex" == *"trotter_kernel_mode"* || "$ex" == *"builder.cpp"* ]]; | |||
There was a problem hiding this comment.
Oops, I meant to put the comment here: Could you please add a link to #2299 in this file itself to explain that is the reason for this test being disabled? (We should probably do that for the others too, but those can probably wait.)
There was a problem hiding this comment.
On second thought, I think these changes should be reverted because I think the required changes would be near here instead:
.And here:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable
building_kernels.pytest for NVQC integration tests (it requires state pointer argument synthesis to work, which requires a fix for #2299)