Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vestigal uses of the old DOXYGEN_SHOULD_SKIP_THIS macro #2978

Merged

Conversation

ericniebler
Copy link
Collaborator

@ericniebler ericniebler commented Nov 28, 2024

Description

i stumbled across two additional uses of the no-longer-used DOXYGEN_SHOULD_SKIP_THIS macro. i suspect they snuck back in when these two memory resource files were moved into cudax.

this pr replaces the old macro with the new _CCCL_DOXYGEN_INVOKED macro.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ericniebler ericniebler requested a review from a team as a code owner November 28, 2024 00:03
Copy link
Contributor

🟩 CI finished in 29m 33s: Pass: 100%/54 | Total: 3h 59m | Avg: 4m 26s | Max: 15m 36s | Hits: 90%/256
  • 🟩 cudax: Pass: 100%/54 | Total: 3h 59m | Avg: 4m 26s | Max: 15m 36s | Hits: 90%/256

    🟩 cpu
      🟩 amd64              Pass: 100%/50  | Total:  3h 47m | Avg:  4m 33s | Max: 15m 36s | Hits:  90%/256   
      🟩 arm64              Pass: 100%/4   | Total: 11m 40s | Avg:  2m 55s | Max:  3m 51s
    🟩 ctk
      🟩 12.0               Pass: 100%/19  | Total:  1h 23m | Avg:  4m 24s | Max: 15m 36s | Hits:  90%/128   
      🟩 12.5               Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 12s
      🟩 12.6               Pass: 100%/33  | Total:  2h 25m | Avg:  4m 24s | Max: 15m 20s | Hits:  90%/128   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 23m | Avg:  4m 24s | Max: 15m 36s | Hits:  90%/128   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 12s
      🟩 nvcc12.6           Pass: 100%/33  | Total:  2h 25m | Avg:  4m 24s | Max: 15m 20s | Hits:  90%/128   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/54  | Total:  3h 59m | Avg:  4m 26s | Max: 15m 36s | Hits:  90%/256   
    🟩 cxx
      🟩 Clang9             Pass: 100%/2   | Total:  6m 46s | Avg:  3m 23s | Max:  3m 43s
      🟩 Clang10            Pass: 100%/2   | Total:  6m 25s | Avg:  3m 12s | Max:  3m 36s
      🟩 Clang11            Pass: 100%/4   | Total: 11m 45s | Avg:  2m 56s | Max:  3m 12s
      🟩 Clang12            Pass: 100%/4   | Total: 11m 48s | Avg:  2m 57s | Max:  3m 06s
      🟩 Clang13            Pass: 100%/4   | Total: 11m 50s | Avg:  2m 57s | Max:  3m 19s
      🟩 Clang14            Pass: 100%/4   | Total: 23m 31s | Avg:  5m 52s | Max: 14m 34s
      🟩 Clang15            Pass: 100%/2   | Total:  6m 39s | Avg:  3m 19s | Max:  3m 20s
      🟩 Clang16            Pass: 100%/4   | Total: 12m 38s | Avg:  3m 09s | Max:  3m 51s
      🟩 Clang17            Pass: 100%/2   | Total:  6m 28s | Avg:  3m 14s | Max:  3m 15s
      🟩 Clang18            Pass: 100%/2   | Total: 18m 09s | Avg:  9m 04s | Max: 15m 05s
      🟩 GCC9               Pass: 100%/2   | Total:  6m 03s | Avg:  3m 01s | Max:  3m 09s
      🟩 GCC10              Pass: 100%/4   | Total: 11m 29s | Avg:  2m 52s | Max:  3m 06s
      🟩 GCC11              Pass: 100%/4   | Total: 11m 51s | Avg:  2m 57s | Max:  3m 11s
      🟩 GCC12              Pass: 100%/7   | Total: 58m 55s | Avg:  8m 25s | Max: 15m 36s
      🟩 GCC13              Pass: 100%/3   | Total:  7m 54s | Avg:  2m 38s | Max:  2m 44s
      🟩 MSVC14.36          Pass: 100%/1   | Total:  8m 14s | Avg:  8m 14s | Max:  8m 14s | Hits:  90%/128   
      🟩 MSVC14.39          Pass: 100%/1   | Total:  8m 39s | Avg:  8m 39s | Max:  8m 39s | Hits:  90%/128   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 12s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/30  | Total:  1h 55m | Avg:  3m 51s | Max: 15m 05s
      🟩 GCC                Pass: 100%/20  | Total:  1h 36m | Avg:  4m 48s | Max: 15m 36s
      🟩 MSVC               Pass: 100%/2   | Total: 16m 53s | Avg:  8m 26s | Max:  8m 39s | Hits:  90%/256   
      🟩 NVHPC              Pass: 100%/2   | Total: 10m 22s | Avg:  5m 11s | Max:  5m 12s
    🟩 gpu
      🟩 v100               Pass: 100%/54  | Total:  3h 59m | Avg:  4m 26s | Max: 15m 36s | Hits:  90%/256   
    🟩 jobs
      🟩 Build              Pass: 100%/49  | Total:  2h 43m | Avg:  3m 20s | Max:  8m 39s | Hits:  90%/256   
      🟩 Test               Pass: 100%/5   | Total:  1h 15m | Avg: 15m 10s | Max: 15m 36s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  2m 36s | Avg:  2m 36s | Max:  2m 36s
      🟩 90a                Pass: 100%/1   | Total:  2m 38s | Avg:  2m 38s | Max:  2m 38s
    🟩 std
      🟩 17                 Pass: 100%/29  | Total:  1h 54m | Avg:  3m 56s | Max: 15m 36s
      🟩 20                 Pass: 100%/25  | Total:  2h 05m | Avg:  5m 00s | Max: 15m 19s | Hits:  90%/256   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 54)

# Runner
43 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

@bernhardmgruber bernhardmgruber merged commit a5d33e0 into NVIDIA:main Nov 28, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants