Add section about SSH signing keys to developer docs. #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
force-pushed
the
ssh_signing_keys
branch
from
e6d069a
to
4126128
Compare
miscco
approved these changes
May 17, 2024
jrhemstad
requested changes
May 17, 2024
There was a problem hiding this comment.
Requesting changes for now as I'm on the fence about putting this in the contributing guide. I don't want to overwhelm new contributors with a bunch of stuff that it seems like they need to do. Especially with this one where it strictly isn't really necessary.
If we do add it, I'd prefer to put in the CI details section here: https://github.com/NVIDIA/cccl/blob/main/ci-overview.md#ci-workflow-details
CONTRIBUTING.md
Outdated
| ```bash | ||
| git commit -m "Brief description of the change" | ||
| ``` | ||
|
|
||
| ### SSH Signing Keys | ||
|
|
||
| CCCL projects require commits to be signed with a cryptographic key. |
There was a problem hiding this comment.
comment: This isn't quite true. Signed commits are only necessary for internal contributors who want CI to run automatically and not require /ok to test.
There was a problem hiding this comment.
Ah, ok, I'd misunderstood that nuance. I'll gladly move it to the ci docs, as long as I have something concise to link (and refer back to myself 😄)
🟩 CI Results [ Failed: 0 | Passed: 274 | Total: 274 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
[skip-tests] Co-authored-by: Michael Schellenberger Costa <[email protected]>
alliepiper
force-pushed
the
ssh_signing_keys
branch
from
602d34a
to
3ad8979
Compare
🟩 CI Results [ Failed: 0 | Passed: 274 | Total: 274 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
jrhemstad
reviewed
May 20, 2024
jrhemstad
reviewed
May 20, 2024
jrhemstad
reviewed
May 20, 2024
[skip-tests]
alliepiper
force-pushed
the
ssh_signing_keys
branch
from
806e437
to
575db8e
Compare
jrhemstad
approved these changes
May 21, 2024
🟩 CI Results [ Failed: 0 | Passed: 274 | Total: 274 ]
|
| # | Runner |
|---|---|
| 232 | linux-amd64-cpu16 |
| 24 | linux-arm64-cpu16 |
| 18 | windows-amd64-cpu16 |
👃 Inspect Changes
Modifications in project?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| libcu++ | |
| CUB | |
| Thrust | |
| CUDA Experimental |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.