Avoid checking unsigned values for negativity

NVIDIA · Dec 2, 2024 · d74285c · d74285c
1 parent 9f8e379
commit d74285c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/cub/cub/detail/fast_modulo_division.cuh b/cub/cub/detail/fast_modulo_division.cuh
@@ -109,11 +109,14 @@ multiply_extract_higher_bits(T value, R multiplier)
 {
   static_assert(supported_integral<T>::value, "unsupported type");
   static_assert(supported_integral<R>::value, "unsupported type");
-  _CCCL_DIAG_PUSH
-  _CCCL_DIAG_SUPPRESS_ICC(186) // pointless comparison of unsigned integer with zero
-  _CCCL_ASSERT(value >= 0, "value must be non-negative");
-  _CCCL_ASSERT(multiplier >= 0, "multiplier must be non-negative");
-  _CCCL_DIAG_POP
+  _CCCL_IF_CONSTEXPR (_CCCL_TRAIT(is_signed, T))
+  {
+    _CCCL_DIAG_PUSH
+    _CCCL_DIAG_SUPPRESS_ICC(186) // pointless comparison of unsigned integer with zero
+    _CCCL_ASSERT(value >= 0, "value must be non-negative");
+    _CCCL_ASSERT(multiplier >= 0, "multiplier must be non-negative");
+    _CCCL_DIAG_POP
+  }
   static constexpr int NumBits = sizeof(DivisorType) * CHAR_BIT;
   using unsigned_t             = unsigned_implicit_prom_t<DivisorType>;
   using larger_t               = larger_unsigned_type_t<DivisorType>;